This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Conversation
Contributor
Author
|
This will end up closing #567. |
This comment has been minimized.
This comment has been minimized.
plasticine
approved these changes
Oct 15, 2018
| ], | ||
| "plugins": [ | ||
| ["relay", {"compat": true, "schema": "app/graph/schema.json"}] | ||
| ["relay", {"compat": true, "schema": "app/graph/schema.json"}], |
Contributor
There was a problem hiding this comment.
Won’t need this anymore!
Contributor
Author
There was a problem hiding this comment.
Oh, really? Can it just be dropped?
Contributor
There was a problem hiding this comment.
Oh wait — sorry, I was thinking about webpack when I wrote this lol. Excuse me, I haven’t had a coffee yet 🙄
| "@babel/polyfill": "^7.0.0", | ||
| "@babel/preset-env": "^7.0.0", | ||
| "@babel/preset-flow": "^7.0.0", | ||
| "@babel/preset-react": "^7.0.0", |
Contributor
Author
There was a problem hiding this comment.
I mean I consider this on us for using stage-0 ;P
Contributor
Author
There was a problem hiding this comment.
There are almost certainly some things we can drop from this list, but this is what we had so I’m keeping them for now. We can make more informed decisions about it in future.
Updates us to Babel 7.0, keeping behaviour otherwise the same.
We need to migrate to https://github.com/gaearon/react-hot-loader at some point anyway, the stuff we were using was multiple years' abandoned!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates us to Babel 7.0, keeping behaviour otherwise the same.
One thing we lose in this transition is the React-specific hot reloading infrastructure, which I don’t believe worked properly as of Webpack 3, let alone version 4. There are new ways to accomplish it which we can explore in a future PR.
The MyBuilds fixes will also be part of completion of #634.