PB-680: add a test step to test with experiment feature flag on #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
force-pushed
the
ming/pb-680
branch
3 times, most recently
from
fe6c3c1 to
700031c
Compare
zhming0
force-pushed
the
ming/pb-680
branch
from
700031c to
0914278
Compare
SorchaAbel
reviewed
Sep 18, 2025
| EXPERIMENTAL_STACKS_API_SUPPORT: true | ||
| plugins: | ||
| - kubernetes: | ||
| podSpecPatch: |
There was a problem hiding this comment.
I wonder for consistency should a podSpec be used here instead of a podSpecPatch.
I think it needs either a complete podSpec OR step-level configuration with podSpecPatch.
SorchaAbel
reviewed
Sep 18, 2025
| - *go-cache-volume | ||
| - *go-mod-cache-volume | ||
| containers: | ||
| - name: container-0 |
There was a problem hiding this comment.
could the name be something more descriptive like tests :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are introducing a pivotal feature flag to the system, which largely does not impact observed behavior on k8s stack, we should run a parallel test suite for it.