SUP-3496: Ensure token is returned to bucket when BK jobs are acquired and failed #535
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While performing testing for #534, I uncovered a scenario where
tryReturnToken()was not being called whenfailJob()was invoked to acquire and fail a job. This created a situation where there were no moreavailable-tokensandnum-in-flightwould be capped out atmax-in-flight. No Kubernetes jobs would be running and the controller would be unable to create any new Kubernetes jobs. Restarting the controller was the only way to resolve this situation, as the token bucket is initialized (filled) withmax-in-flighttokens atStart().Fixes #302