Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vimeo slide type #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

krismeister
Copy link

Hey,

This is a good lib, thanks alot for your work.

I added functionality for vimeo. The 3 main edits are:

  • Moved all the slide creation into: base._slideCreator
  • Added slide type VIMEO
  • Added vars.last_slide to hold index of last slide
  • Added base._cleanOldSlide() to stop video from playing when it animates out.

I've also included a start_webrick.rb which starts a local server at the location of the files. The local server part is required to interact with the VIMEO api. See the readme for more info.

The demo.html is setup to set test the slides.

The data structure adds a 'type' var, but it defaults to type image if none is entered.

My skin needs are different than the one default theme in demo, so i haven't tried to fix it up. Currently the Vimeo controls are hidden by the progress bar. However you can right click to bring up a menu for VIMEO.

The new structure should make adding new types of slides in the future simple to implement.

If theres any thing else I can do to help you out to get this functionality added please tell me.

thanks again,
Kris

@numediaweb
Copy link

This is a great feature!
Is it you who created this code:http://pastebin.com/V1NPFkTR after request from (http://javascriptquestions.com/question/showChrono/id/52)
I can see it support both YouTube and Vimeo videos but not yet integrated in the main core files :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants