org_members: Display username as fallback #9643
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displaying members in the organization members list, the username will now be used as a fallback if the email and full name are not available. This ensures a consistent display of user identifiers.
sluongng
force-pushed
the
sluongng/usename-fallback
branch
from
3ca3dcb to
c825404
Compare
bduffany
reviewed
Jun 12, 2025
| @@ -250,7 +250,8 @@ export default class OrgMembersComponent extends React.Component<OrgMembersProps | |||
| <div className="affected-users-list"> | |||
| {selectedMembers.map((member) => ( | |||
| <div className={`affected-users-list-item ${this.isLoggedInUser(member) ? "flagged-self-user" : ""}`}> | |||
| {member?.user?.email || member?.user?.name?.full} {iconFromAccountType(member.user?.accountType)} | |||
| {member?.user?.email || member?.user?.name?.full || member?.user?.username}{" "} | |||
There was a problem hiding this comment.
This implementation looks inconsistent with the accountLabel implementation in org_join_requests.tsx (here we prefer email but in org_join_requests.tsx we prefer username). Could we extract an accountName function from that accountLabel function (could be added to app/auth/user.ts) and call it both here and in accountLabel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying members in the organization members list, the username
will now be used as a fallback if the email and full name are not
available. This ensures a consistent display of user identifiers.