bzlmod: enable by default #9027
Draft
+11
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/enable-bzlmod
branch
2 times, most recently
from
dfd0b23 to
ed87adc
Compare
fmeum
approved these changes
Apr 22, 2025
| @@ -15,12 +15,22 @@ import %workspace%/shared.bazelrc | |||
| # PUBLIC REPO EXCLUSIVE CONFIGS # | |||
| ################################# | |||
|
|
|||
| # Enable bzlmod by default | |||
There was a problem hiding this comment.
These are the defaults in Bazel 8, so this shouldn't be needed.
There was a problem hiding this comment.
Good call. I probably should move the disabled-bzlmod flag out of the shared.bazelrc file instead.
Enabled bzlmod by default in .bazelrc. This moves the project closer to fully migrating to bzlmod. Updated buildbuddy.yaml to explicitly test the old WORKSPACE mode and renamed the platform configs in .bazelrc to align with the new default. Depend on #9026
sluongng
force-pushed
the
sluongng/enable-bzlmod
branch
from
b15bd66 to
157bc94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled bzlmod by default in .bazelrc. This moves the project closer
to fully migrating to bzlmod.
Updated buildbuddy.yaml to explicitly test the old WORKSPACE mode
and renamed the platform configs in .bazelrc to align with the
new default.
Depend on #9026