Merge pull request #702 from bugsnag/disable-appium-logs

Disable automatic attempts to get and write device log

CHANGELOG.md

@@ -1,9 +1,10 @@
-# 9.19.0 - TBD
+# 9.19.0 - 2024/11/18
 
 ## Enhancements
 
 - Removed deprecated safari 15 & 16 from BitBar configuration, added safari 17 & 18 [701](https://github.com/bugsnag/maze-runner/pull/701)
 - Handle failing appium session better [696](https://github.com/bugsnag/maze-runner/pull/696)
+- Disable automatic attempts to acquire test device logs in appium scenarios [702](https://github.com/bugsnag/maze-runner/pull/702)
 
 ## Fixes
 

lib/maze/hooks/appium_hooks.rb

@@ -39,8 +39,6 @@ def after(scenario)
           # Close the app - without the sleep, launching the app for the next scenario intermittently fails
           system("killall -KILL #{Maze.config.app} && sleep 1")
         elsif [:bb, :bs, :local].include? Maze.config.farm
-          write_device_logs(scenario) if scenario.failed?
-
           # Reset the server to ensure that test fixtures cannot fetch
           # commands from the previous scenario (in idempotent mode).
           begin

lib/maze/maze_output.rb

@@ -90,7 +90,7 @@ def write_requests
       end
     end
 
-    # Pulls the logs from the device if the scenario fails
+    # Writes a set of logs to a device logs file
     # @param logs [Array<String>] The lines of log to be written
     def write_device_logs(logs)