Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Code-bundle-id should be typed as a string in the meow config #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emmahoggan
Copy link

Code-bundle-id should be typed as a string in the meow config so that it isn't processed as a number.

E.g.,--code-bundle-id=953531e1 was uploading a sourcemap with bundle id 9535310

@johnkiely1
Copy link
Member

Hi @emmahoggan.
Thanks for the PR.
This seems like a reasonable thing to do. We will review in due course.

@magrinj
Copy link

magrinj commented Oct 5, 2020

Hi there, it's something really needed ! Any plan to ship it ?
@johnkiely1

@emmahoggan
Copy link
Author

@magrinj - I also needed the fix sooner than later. Until it gets added, I've just created a fork with the change. You're welcome to piggyback off if it if you like:

npm install -g emmahoggan/bugsnag-sourcemaps#code-bundle-id-type

@magrinj
Copy link

magrinj commented Oct 5, 2020

@emmahoggan Thanks for the share, I'll use your patch until it gets added !

@abigailbramble
Copy link

Hi @magrinj - we don't have a timescale for this at the moment. We will be sure to update back here when we have an update.

@abigailbramble abigailbramble added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Oct 6, 2020
@magrinj
Copy link

magrinj commented Oct 6, 2020

@phillipsam Ok, let us know as it's really a small change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants