This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Fix windows paths #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the expected paths to use posix separators on Windows systems.
Convert uploaded urls and source paths to posix style paths
|
Thanks for the PR. We'll need to do some work on this to review the PR and work out what's happening with the tests, which we won't be able to schedule for a while with the other team priorities. We'll raise this on our backlog to take a look at when time permits. For now you could fork the repository to start using your fix. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a problem uploading sourcemaps from a Windows system using the
--directoryflag. Paths were being uploaded with backslashes which caused bugsnag not to pick up the sourcemaps correctly.This replaces any backslashes in
minifiedUrlandsourceswith the corresponding posix style path. As an added benefit the tests suite is closer to passing on Windows.Unfortunately, there is some weirdness with the sorting of the arrays that causes them to sort randomly. I've fiddled with the
sort()calls but the best I could do was make the tests pass every other run.