Release v6.25.2 #775
Merged
Release v6.25.2 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use docker compose exec to run queue commands in maze runner tests
The current implementation checks if `auto_notify` is an instance of
`TrueClass` or `FalseClass` (in that order). As this is a "hot path" as
far as Bugsnag is concerned (runs on all notifications), we can consider
applying the following optimizations:
- `true` and `false` are singleton instances of `TrueClass` and
`FalseClass`, respectively. Therefore, we can rely on the slightly
faster `.equal?` check, which relies on object identity.
- `false` is the default for the method, so is likely the most common
usage, so we can invert the order of the check and check for `false`
before `true`, to benefit from short circuiting in the more common case.
This new implementation is faster in the `false` and non-boolean cases,
and while it is slower in the `true` case (because of the order
inversion), it is still faster than the previous approach was in the
`false` case.
We can test this using the following benchmark:
require "benchmark/ips"
[
false, # Default – Probably most common case
true, # Override – Probably accounts for almost all other usage
{}, # Deprecated – Probably barely any usage
].freeze.each do |auto_notify|
Benchmark.ips do |x|
x.compare!
x.report("#{auto_notify}.is_a? TrueClass or #{auto_notify}.is_a? FalseClass (status quo)") do
auto_notify.is_a? TrueClass or auto_notify.is_a? FalseClass
end
x.report("false.equal? #{auto_notify} or true.equal? #{auto_notify} (proposed) ") do
false.equal? auto_notify or true.equal? auto_notify
end
end
end
which produces the following results:
Implementation |`false` |`true` |`{}`
----------------------------------------------------------------------------|--------------------|--------------------|--------------------
`auto_notify.is_a? TrueClass or auto_notify.is_a? FalseClass` _(status quo)_|11.978M (± 0.6%) i/s|17.122M (± 1.3%) i/s|11.814M (± 0.5%) i/s
`false.equal? auto_notify or true.equal? auto_notify` _(proposal)_ |17.955M (± 0.4%) i/s|13.553M (± 1.6%) i/s|13.420M (± 2.5%) i/s
…check Optimize `auto_notify` boolean check
tomlongridge
approved these changes
Feb 2, 2023
imjoehaines
force-pushed
the
release/v6.25.2
branch
from
1cb0747 to
7454f4b
Compare
tomlongridge
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
Bugsnag.notify| #774
| sambostock