Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js example to v13 #1958

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

rafaelalmeidatk
Copy link

@rafaelalmeidatk rafaelalmeidatk commented May 7, 2023

Goal

👋 Hi there, I recently added Bugsnag to a project and noticed the example is using a very old version of Next.js (from 2021!) so I went ahead and updated some of the files. Since I kept the pages dir I didn't have to change too much stuff, most of the changes are to simplify the code

Changeset

  • Updated all dependencies (I worked with a fresh lockfile so that's why the diff is large)
  • Added type-checking to the next.config.js file
  • Changed hardcoded internal strings with exported variables from next/constants
  • Removed unnecessary NEXT_IS_SERVER env variable
  • Removed usage of IgnorePlugin from the custom webpack config. Next.js does server-side code elimination so this library isn't bundled to the client

Testing

I tested the updated version with a new project in the Bugsnag dashboard

@johnkiely1
Copy link
Member

Hey @rafaelalmeidatk, thanks for this PR, we will review as soon as priorities allow.

@johnkiely1 johnkiely1 added the backlog We hope to fix this feature/bug in the future label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants