Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Replace the binary event writer with a signal-safe JSON encoder.
Design
Using the same JSON encoder we use in
bugsnag-cocoa
our signal handler now dumps the event state directly as JSON, allowing more flexibility in the in-memory event model.The native events are still written to the
native
directory since thediscardClasses
cannot be evaluated during the crash. Instead a newReportDiscardScanner
class will evaluatediscardClasses
andenabledReleaseStages
on delivery, using aJsonReader
to allow early-exit when either:Testing
Relied on existing tests, with a simple unit test to ensure that legacy native events are discarded.