Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .markdownlint.json to ignore first line as heading #537

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

RRudder
Copy link
Contributor

@RRudder RRudder commented Sep 16, 2024

Ignoring first line as heading allows a template to begin with the description contents for each submission type.

Ignoring first line as heading allows a template to begin with the description contents for each submission type.
Copy link
Contributor

@vortexau vortexau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given recent changes to templates now removes the header, I am of the opinion that it would be better for the linter to fail for any template that still contains the header.
This change would then probably be "first-line-heading": true, and the linter should then fail if a heading exists on the first line. I think. Test that before committing 😅

`"MD041": false,` tells the linting tool to ignore the rule that says that the first line must start with a heading. e.g. # Title of File.

This will allow the template.md files to start with the description of the vulnerability. A feature which will decrease the time it takes  for penetration testing report creation.
@RRudder
Copy link
Contributor Author

RRudder commented Sep 25, 2024

While the latest change has not solved for flagging files that do start with a heading, e.g. # Title of File. It does solve the GitHub Action linting tool failing on files that do not start with a heading. A feature that has been requested for pen test report creation.

@vortexau vortexau merged commit a9f9c9c into master Sep 26, 2024
3 checks passed
@vortexau vortexau deleted the RRudder-patch-3 branch September 26, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants