Skip to content

Commit

Permalink
Update protocompile to bring in a fix for buf breaking issue (#2968)
Browse files Browse the repository at this point in the history
I was doing manual QA of buf breaking with an Editions file and ran into
something strange, related to the C++ string type and Java UTF8
validation checks.

The issue turned out to be a bug in the helper function in
`protocompile` that resolves custom features. This pulls in a fix to
that function.
  • Loading branch information
jhump committed May 13, 2024
1 parent faf44b1 commit 24640ae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
buf.build/gen/go/bufbuild/registry/protocolbuffers/go v1.33.0-20240401180337-569d290ee4cc.1
connectrpc.com/connect v1.16.1
connectrpc.com/otelconnect v0.7.0
github.com/bufbuild/protocompile v0.13.1-0.20240509185927-54ef548a6198
github.com/bufbuild/protocompile v0.13.1-0.20240510201809-752249dfc37f
github.com/bufbuild/protoplugin v0.0.0-20240323223605-e2735f6c31ee
github.com/bufbuild/protovalidate-go v0.6.2
github.com/bufbuild/protoyaml-go v0.1.9
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ github.com/Microsoft/go-winio v0.6.1 h1:9/kr64B9VUZrLm5YYwbGtUJnMgqWVOdUAXu6Migc
github.com/Microsoft/go-winio v0.6.1/go.mod h1:LRdKpFKfdobln8UmuiYcKPot9D2v6svN5+sAH+4kjUM=
github.com/antlr4-go/antlr/v4 v4.13.0 h1:lxCg3LAv+EUK6t1i0y1V6/SLeUi0eKEKdhQAlS8TVTI=
github.com/antlr4-go/antlr/v4 v4.13.0/go.mod h1:pfChB/xh/Unjila75QW7+VU4TSnWnnk9UTnmpPaOR2g=
github.com/bufbuild/protocompile v0.13.1-0.20240509185927-54ef548a6198 h1:F6BJmDCt7Uas+cW2iq9dA6NclN6EcXZt7JXB2V8pm3c=
github.com/bufbuild/protocompile v0.13.1-0.20240509185927-54ef548a6198/go.mod h1:QJcgsTVPSBEMt+/3i2M/RpwjZc+DAXyPPDg0slmMk4c=
github.com/bufbuild/protocompile v0.13.1-0.20240510201809-752249dfc37f h1:cQLFPZXf32tbTLzUTg0n69Vi5kddhUiZMzpMzKRW0XU=
github.com/bufbuild/protocompile v0.13.1-0.20240510201809-752249dfc37f/go.mod h1:QJcgsTVPSBEMt+/3i2M/RpwjZc+DAXyPPDg0slmMk4c=
github.com/bufbuild/protoplugin v0.0.0-20240323223605-e2735f6c31ee h1:E6ET8YUcYJ1lAe6ctR3as7yqzW2BNItDFnaB5zQq/8M=
github.com/bufbuild/protoplugin v0.0.0-20240323223605-e2735f6c31ee/go.mod h1:HjGFxsck9RObrTJp2hXQZfWhPgZqnR6sR1U5fCA/Kus=
github.com/bufbuild/protovalidate-go v0.6.2 h1:U/V3CGF0kPlR12v41rjO4DrYZtLcS4ZONLmWN+rJVCQ=
Expand Down

0 comments on commit 24640ae

Please sign in to comment.