Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Dataset Classes for Classification Task #39

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

michellepi
Copy link
Collaborator

I have created modifications to the dataset classes to allow us to replicate the classification tasks in each datasets corresponding work

I suggest two changes:

  1. Choice to split manually (existing method) or according to split provided in the csv
  2. Choice to return labels for classification task, brain plane for FetalPlaneDataset, and plane and country for AfricanFetalPlaneDataset

xfetus/xfetus.py Outdated
@@ -77,12 +91,17 @@ def __getitem__(self, idx):

## Downsample image for SRGAN
ds_image = resize(
image.cpu().numpy(),
image,
Copy link
Member

@mxochicale mxochicale Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my setup I need to use image.cpu().numpy() to solve TypeError: Cannot interpret 'torch.float32' as a data type. Let's check that we have the right data format.

@mxochicale
Copy link
Member

Hi @michellepi

Just to let you know that I re-based michelle_clf branch with latest changes in the main branch. Feel free to commit any changes. Thanks, --Miguel

@mxochicale
Copy link
Member

Hi @michellepi

xfetus_classifier.ipynb looks great. Would you please help with the following comments. Then we can proceed to merge it.

  1. Add introduction section to your notebook as what we did at the beginning of this notebook: https://github.com/budai4medtech/xfetus/blob/michelle_clf/examples/curating_datasets/curating_african_fetal_us_datasets.ipynb
  2. Clean notebook as there are some cells that seems to be flooded the notebook e.g., "Evaluate Brain Planes"
  3. Create a new path "classifiers" under "examples" and move your notebook there and rename xfetus_classifier.ipynb as baseline-classifiers.ipynb
  4. Add a basic README in examples/classifiers.

Thanks, Miguel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants