Issue #199: Put the closure in heap to avoid the stack overflowed in Debug
#200
Conversation
| for e in self { | ||
|
|
||
| // stable sort | ||
| let mut values: Vec<&T> = self.iter().collect(); |
There was a problem hiding this comment.
This should be the change mentioned by #256, it should not be in this pull request
There was a problem hiding this comment.
Sort the values in ascending order, and encode the elements into the buffer. for Issue #256
There was a problem hiding this comment.
I mean it should be included in a new request for issue #256, and in the entire pull request, it seems, this is the only substantive change?
There was a problem hiding this comment.
This file only seems to have changed in format, and I compared it to see no substantive changes, and the changes seem to have nothing to do with the problem the target is trying to fix
There was a problem hiding this comment.
Yes, It's only format change. It occurs when I merged the main branch to my local branch, and the IDE changed the format automatically, I think we shoud define the standuard configure of format for IDE.
There was a problem hiding this comment.
From the log of your pull request's commits, the whole operation list is a bit complicated and confused, you should make the relevant changes for each issue frok a separate branch and then create the pull request, not mix it on a larger functional branch and bring up part of the commit inside as a pull request
No description provided.