Fix:nil pointer #959
Open
Fix:nil pointer #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Oct 28, 2024
| @@ -1713,6 +1713,9 @@ func signRawTransaction(icmd interface{}, w *wallet.Wallet, chainClient *chain.R | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if result == nil { | |||
| return nil, errors.New("the utxo has been spent") | |||
There was a problem hiding this comment.
nit: the linter wants you to define this error as a package-level variable. So just add it to the top of the file with a name like errUtxoSpent and use it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when spending an already used UTXO: “runtime error: invalid memory address or nil pointer dereference”
According to my observation, in btcwallet/rpc/legacyrpc/methods.go:1716 the call to hex.DecodeString(result.ScriptPubKey.Hex) with the parameter “result” is nil. This is because when calling resp.Receive() on line 1712, if you use a spent UTXO, it will return (nil,nil), so need to handle the error if result is nil.