Improve reflection #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR is dependent on #31, #32, and #34. Those should be reviewed first.
In the early days, the only way to extend Reposcanner was to modify its source; this meant every analysis had to be written as a branch in this repository, and you had to merge branches to share analyses.
This PR allows analyses to be defined externally, so long as they are importable, e.g.
my_module:MyAnalyses. The old way of writing justMyAnalysis(whereMyAnalysisis some analysis written directly intoreposcanner.contrib) will still work but will trigger a deprecation warning. See the updated documentation inREADME.md.