This repository was archived by the owner on Mar 7, 2019. It is now read-only.
Fix addProduct method to Order #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added composer suppport
Updated composer.json to have a correct minimum-stability
Removing Symfony, as it's not required to run the API client.
Fix error cant modify overloaded property when adding a product with addProduct method
| @@ -69,6 +70,8 @@ public function __set($columnName, $value) | |||
| */ | |||
| public function addProduct(array $data = array()) | |||
| { | |||
| $products = $this->products; | |||
There was a problem hiding this comment.
Add an empty instantiation check to be safe, and I'll take it: $products = is_null($this->products) ? array() : $this->products;
I would say to use good ole' elvis, but we need to support pre-elvis operators.
philcali
force-pushed
the
master
branch
2 times, most recently
from
2c66f44 to
dd7b765
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.