Skip to content

New peddep landing page graph #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: peddep-landing-page
Choose a base branch
from

Conversation

jessica-cheng
Copy link
Contributor

@jessica-cheng jessica-cheng requested a review from rcreasi May 22, 2025 18:50
Copy link
Contributor Author

@jessica-cheng jessica-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcreasi I haven't created a new Plotly graph from scratch in a while and this is one of the first few times we're querying directly from Breadbox. I've noticed you have been writing a lot of custom hooks lately to fetch data from Breadbox and I was wondering if you can give a review on best ways to organize such code moving forward.

(async () => {
try {
// Get depmap models data
const dimensionType = await bapi.getDimensionType("depmap with peddep");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD: Change to depmap_model after confirming the new column names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant