[CTM-133] Reverse call-caching order and not check old entries

[lucymcnatt]

Description

Release Notes Confirmation

CHANGELOG.md

• I updated CHANGELOG.md in this PR
• I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

• I added a suggested release notes entry in this Jira ticket
• I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

[LizBaldo]

The changes look good to me, I only have a couple of minor comments. I am guessing that a few integration tests will need to be updated if they expected older cache hits? I suspect the AWS job queue is stuck by a misconfigured resource job as well if the tests are timing out

[aednichols]

Looks good to me 👍

Deployment note:

We should benchmark how long this Liquibase takes in production.

I believe recent versions of MySQL support instant add columns, but we should verify that it works in practice on our instance, with this particular changeset.

My clone is still around, so that would be a good place to try it.

[aednichols]

It looks like at least one call caching test is failing, I would recommend running it locally to observe how it interacts with the database.

Metadata mismatch for calls.call_cache_cha_cha.read_files_failOnStderr_expression.callCaching.hit - expected: true but got: false

As well as some sort of column type semantics in the DBMS suite:

[info] LiquibaseComparisonSpec:
[info] Liquibase Comparison for Engine MySQL 
[info] - should match the Slick schema for column CALL_CACHING_ENTRY.CREATED_AT *** FAILED *** (1 millisecond)
[info]   for type TIMESTAMP(default = CURRENT_TIMESTAMP) vs. TIMESTAMP(default = null): ColumnType("TIMESTAMP", None) was not equal to ColumnType("DATETIME", None) (LiquibaseComparisonSpec.scala:93)

[lucymcnatt]

Looks good to me 👍

Deployment note:

We should benchmark how long this Liquibase takes in production.

I believe recent versions of MySQL support instant add columns, but we should verify that it works in practice on our instance, with this particular changeset.

My clone is still around, so that would be a good place to try it.

Tried it on your clone and it took ~0.5 secs, so I think we should be good!