Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WX-926 GCP Batch Backend Executor Test Fix #7588

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

WX-926 GCP Batch Backend Executor Test Fix #7588

wants to merge 16 commits into from

Conversation

dspeck1
Copy link
Collaborator

@dspeck1 dspeck1 commented Nov 25, 2024

Description

Fix the backend executor test by correcting the name of the backend from batch to GCPBATCH. The test was previously failing because a backend was not getting matched to authenticate to GCS.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • [ X] I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@dspeck1 dspeck1 requested a review from a team as a code owner November 25, 2024 19:38
@aednichols aednichols changed the title GCP Batch Backend Executor Test Fix WX-926 GCP Batch Backend Executor Test Fix Nov 26, 2024
dspeck1 and others added 11 commits December 6, 2024 15:26
@dspeck1
Fix GCPBATCH provider name in include.
e447209
@dspeck1
Fix reference to batch sub configuration header and documentation.
5bb90df
@dspeck1
[DO NOT COMMIT]. Commented out batch-requests timeout settings as the…
4c6ef6c 
…y appear to not be used.
@aednichols
Merge branch 'develop' into gcp-batch-backend-execution-actor-test
34e0504
@dspeck1
Revert commenting out batch parameters. Fix auth code section in test…
d689d1e 
… to proper name.
@dspeck1
Merge remote-tracking branch 'origin/gcp-batch-backend-execution-acto…
7efcffa 
…r-test' into gcp-batch-backend-execution-actor-test
@dspeck1
Fix batch configuration block in tests.
295dfd5
@dspeck1
Update failure messages with actual failure messages. Create new requ…
c317b28 
…est pays test as the error message is different between GCPBatch and PAPI.
@dspeck1
Update expected error message in GCP requestor pays for GCP Batch.
7501d9a
@dspeck1
Update failed message.
2ec1240
@dspeck1
Update expected error message gcp requester pays. Correct config attr…
70582b1 
…ibute configuration for test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aednichols aednichols Awaiting requested review from aednichols

@mcovarr mcovarr Awaiting requested review from mcovarr

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
GCP Batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dspeck1 @aednichols @jgainerdewar