[AN-341] Pin CI to use MySQL 8.0.40 #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salonishah11
changed the title
aednichols
approved these changes
Feb 6, 2025
salonishah11
changed the title
LizBaldo
approved these changes
Feb 11, 2025
build.sbt
Outdated
| "com.dimafeng" %% "testcontainers-scala-mysql" % testcontainersScalaV % Test, | ||
| "com.dimafeng" %% "testcontainers-scala-mongodb" % testcontainersScalaV % Test, | ||
| "org.flywaydb" % "flyway-core" % "7.3.2" % Test, | ||
| "org.flywaydb" % "flyway-core" % "7.3.2" % Test, // Starting 10.0.0 Flyway only supports Java 17. Agora is on Java 11 |
There was a problem hiding this comment.
Nit, do you want to add the link to the JIRA ticket you created to do the upgrade?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://broadworkbench.atlassian.net/browse/AN-341
Flyway only supports until MySQL version 8.1. Upgrading Agora to 8.4.3 SQL version throws below warning.
Reference: https://documentation.red-gate.com/flyway/reference/supported-databases/mysql
Also, only Java 17 is supported starting Flyway version 10.0.0 and 8.1 is officially supported after this version. The tests were already using MySQL 8.0. This PR pins it to specific version i.e. 8.0.40.