Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jupyter Notebooks #5

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

dr2633
Copy link

@dr2633 dr2633 commented Sep 25, 2024

Hi! Thanks for making this repository and look forward to contributing.

I will be adding Jupyter notebooks converted from the markdown files for each lesson. I can then add these within the Google Doc for the tutorials.

-- Derek

I am adding a directory that contains Jupyter notebooks for each lesson. These will then be added as links in the Google Doc tutorials:

https://docs.google.com/document/d/1jtVEmi5UZgKFmIzb9cR3PmbG7PQ7fD328oT_KF0sjks/edit
Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

It should be safe to Approve and Run the workflows that need maintainer approval.

@jlchang
Copy link
Collaborator

jlchang commented Sep 26, 2024

Hi @dr2633,

Thanks for your PR. I'm curious whether you're looking for the official Library Carpentries repo for this content? Our plan for this Broad workshop was to have Colab notebooks for each episode. (Since we'll be using Colab during the workshop, Colab notebooks seemed like the right choice in case there are subtle differences between the two platforms). It'd be great to chat more about your thinking and whether this repo is the right landing place for your notebooks. I've followed you on X (@lanhsin on X, not Github) if you want to chat more directly.

@dr2633
Copy link
Author

dr2633 commented Sep 26, 2024

Hi @jlchang,

Thank you for your feedback! I will push the notebooks to the Library Carpentries repo as suggested. Currently, I am adding the notebooks within this repository and updating the paths in Google Colab to ensure they pull from the files there in Drive. I’ll reach out on X to chat more directly and discuss further.

@dr2633
Copy link
Author

dr2633 commented Sep 26, 2024

I have added the ipynb files into the Google Doc for the tutorials:
https://docs.google.com/document/d/1jtVEmi5UZgKFmIzb9cR3PmbG7PQ7fD328oT_KF0sjks/edit

Let me know if you have any questions. My X account is @DerekRosenzwei3.

@jlchang
Copy link
Collaborator

jlchang commented Sep 27, 2024

Thanks dr2633. I'm running a workshop on this material today and won't have time to review your PR until early next week.
FYI, I have now followed both @dr2633 and @DerekRosenzwei3 on X, feel free to DM me there to discuss further.

@dr2633
Copy link
Author

dr2633 commented Sep 27, 2024

Great, thanks @jlchang and best of luck with your workshop today. Let me know when you have any questions in reviewing PR. I have kept the notebooks consistent with the md files.

I would be happy to add more examples and changes if that would be helpful for the tutorials.

@dr2633
Copy link
Author

dr2633 commented Oct 10, 2024

Hi @jlchang, can these notebooks be merged in the repository? Let me know if you have any questions or anything else I can add here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants