fix(terraform): Handle new resource type for CKV_GCP_73 #7023
+145
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
reviewed
Feb 23, 2025
| @@ -38,6 +39,32 @@ def scan_resource_conf(self, conf: Dict[str, List[Any]]) -> CheckResult: | |||
| if rule.get("preview") == [True]: | |||
| return CheckResult.FAILED | |||
| return CheckResult.PASSED | |||
|
|
|||
| resource_name = conf.get("name")[0] | |||
There was a problem hiding this comment.
Will we always have a name? I know the name attribute can be omitted from the resource but I am not sure if we populate this field in a default way in this case. I also saw in other locations we check if conf["name"] is null.
maxamel
reviewed
Feb 23, 2025
| if expr.get("expression") == "evaluatePreconfiguredExpr('cve-canary')": | ||
| if rule.get("action") == "allow": | ||
| return CheckResult.FAILED | ||
| if rule.get("preview"): |
There was a problem hiding this comment.
From what I saw if preview=True we do not enforce the action, so why are we failing here?
Also, perhaps before the action check we need to first check the preview since in case it's True the action won't kick in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Handles google_compute_security_policy_rule
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances the CloudArmorWAFACLCVE202144228 check to handle the new
google_compute_security_policy_ruleresource type. Modifies thecheckmethod in theCloudArmorWAFACLCVE202144228class to evaluate connected security policy rules. Updates test files to include new test cases for separate security policy and rule resources.Modified files (2)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)