Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Add multiple checks #7016

Merged
merged 8 commits into from
Feb 18, 2025
Merged

feat(terraform): Add multiple checks #7016

merged 8 commits into from
Feb 18, 2025

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Feb 16, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

CKV_GCP_126 aligns to b63e36e5-576d-48e3-8b92-a325c3e89b73 GCP Vertex AI Workbench user-managed notebook has vTPM disabled
CKV_GCP_127 aligns to 32863163-9440-4b46-9c61-613cb2a2da5e GCP Vertex AI Workbench user-managed notebook has Integrity monitoring disabled
CKV2_GCP_37 aligns to 646f94d4-6499-4c24-99ec-949a1ea6f311 GCP public-facing (external) regional load balancer using HTTP protocol
CKV2_GCP_38 aligns to 8e46318c-34c8-4751-86e8-86b7dd971e07 GCP public-facing (external) global load balancer using HTTP protocol

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes




Generated description

Below is a concise technical summary of the changes proposed in this PR:

Adds multiple security checks for Google Cloud Platform (GCP) resources. Implements new checks for Vertex AI Notebook instances to ensure they are launched with Shielded VM and Integrity Monitoring enabled. Introduces checks for GCP compute forwarding rules to prevent the use of HTTP proxies with external load balancing schemes. Creates corresponding test files and resources for these new checks.

TopicDetails
GCP Security Checks Implements new security checks for GCP Vertex AI Notebook instances and compute forwarding rules
Modified files (4)
  • checkov/terraform/checks/resource/gcp/VertexAINotebookEnsureIntegrityMonitoring.py
  • checkov/terraform/checks/resource/gcp/GoogleVertexAINotebookShieldedVM.py
  • checkov/terraform/checks/graph_checks/gcp/GCPComputeGlobalForwardingRuleCheck.yaml
  • checkov/terraform/checks/graph_checks/gcp/GCPComputeRegionalForwardingRuleCheck.yaml
Latest Contributors(0)
UserCommitDate
Test Implementation Adds test files and resources for the new GCP security checks
Modified files (9)
  • tests/terraform/checks/resource/gcp/test_VertexAINotebookEnsureIntegrityMonitoring.py
  • tests/terraform/checks/resource/gcp/test_GoogleVertexAINotebookShieldedVM.py
  • tests/terraform/graph/checks/test_yaml_policies.py
  • tests/terraform/graph/checks/resources/GCPComputeGlobalForwardingRuleCheck/main.tf
  • tests/terraform/graph/checks/resources/GCPComputeRegionalForwardingRuleCheck/main.tf
  • tests/terraform/graph/checks/resources/GCPComputeGlobalForwardingRuleCheck/expected.yaml
  • tests/terraform/graph/checks/resources/GCPComputeRegionalForwardingRuleCheck/expected.yaml
  • tests/terraform/checks/resource/gcp/example_VertexAINotebookEnsureIntegrityMonitoring/main.tf
  • tests/terraform/checks/resource/gcp/example_GoogleVertexAINotebookShieldedVM/main.tf
Latest Contributors(2)
UserCommitDate
tsmithv11fix-terraform-Convert-...December 03, 2024
bo156fix-terraform-Temporar...July 08, 2024
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 marked this pull request as ready for review February 16, 2025 06:17
@tsmithv11 tsmithv11 merged commit c59584c into main Feb 18, 2025
43 of 44 checks passed
@tsmithv11 tsmithv11 deleted the new-checks-feb25 branch February 18, 2025 10:47
Saarett pushed a commit that referenced this pull request Feb 18, 2025
* Add check 1

* Fix flake8

* Check 2

* check 3

* Fix tests

* fix check3

* Add check 4
Saarett pushed a commit that referenced this pull request Feb 18, 2025
* Add check 1

* Fix flake8

* Check 2

* check 3

* Fix tests

* fix check3

* Add check 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants