feat(terraform): adding 3 policies & tests #7011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
TomerSegev241
changed the title
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested changes
Feb 17, 2025
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
||
| def scan_resource_conf(self, conf: Dict[str, Any]) -> CheckResult: | ||
| if "image_owner_alias" in conf or 'owner_id' in conf: |
There was a problem hiding this comment.
These are Attribute Reference attributes, so they are not written by the user for the resource type.
There was a problem hiding this comment.
yet if they are specified (doesn't matter the actual value of it) its a best practice to avoid WhoAMI attack. So if it is declared it's enough in order to pass the policy. is that makes sense?
There was a problem hiding this comment.
I'm saying that a user can't specify them in their Terraform code, so this would only apply to plan file scans. This check is effectively just looking for * in name and I don't think that is the intention.
| categories = [CheckCategories.NETWORKING] | ||
| super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources) | ||
|
|
||
| def scan_resource_conf(self, conf: Dict[str, Any]) -> CheckResult: |
| from typing import Dict, Any | ||
|
|
||
| from checkov.common.models.enums import CheckResult, CheckCategories | ||
| from checkov.terraform.checks.resource.base_resource_check import BaseResourceCheck |
There was a problem hiding this comment.
@TomerSegev241 users can't define owner in the resource type. I think you need a data type check instead.
| @@ -0,0 +1,29 @@ | |||
| # DataCatalogWithPublicAccess | |||
There was a problem hiding this comment.
I'd remove this comment
checkov/terraform/checks/resource/azure/StorageSyncServicePermissiveAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/oci/DataCatalogWithPublicAccess.py
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+21
| else: | ||
| return CheckResult.FAILED |
There was a problem hiding this comment.
Not strictly necessary, but ok
checkov/terraform/checks/resource/azure/VMDiskWithPublicAccess.py
Outdated
Show resolved
Hide resolved
checkov/terraform/checks/resource/oci/DataCatalogWithPublicAccess.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
…issiveAccess.py Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
…ess.py Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
…ess.py Co-authored-by: Taylor <[email protected]>
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
TomerSegev241
requested a deployment
to
scan-security
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Implements three new security policies for Terraform resources and adds corresponding tests. The policies address potential vulnerabilities in AWS AMI configuration, Azure Storage Sync Service and Managed Disk network access, and OCI Data Catalog public access. New classes are created to perform these checks, along with test files and example configurations to validate the policies.
Modified files (4)
Latest Contributors(0)
Modified files (8)
Latest Contributors(0)