fix: NonProjectFileWritingAccessProvider.isWriteAccessAllowed was cal…

…led on EDT
bric3 · Nov 10, 2024 · 2f81c95 · 2f81c95
1 parent 0f02cef
commit 2f81c95
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/plugin/src/main/kotlin/com/github/bric3/excalidraw/editor/ExcalidrawEditorProvider.kt b/plugin/src/main/kotlin/com/github/bric3/excalidraw/editor/ExcalidrawEditorProvider.kt
@@ -14,14 +14,14 @@ class ExcalidrawEditorProvider : AsyncFileEditorProvider, DumbAware {
     override fun createEditor(project: Project, file: VirtualFile): FileEditor = createEditorAsync(project, file).build()
     override fun getEditorTypeId() = "excalidraw-jcef-editor"
     override fun getPolicy() = FileEditorPolicy.HIDE_DEFAULT_EDITOR
-    override fun createEditorAsync(project: Project, file: VirtualFile): AsyncFileEditorProvider.Builder =
-        object : AsyncFileEditorProvider.Builder() {
-            override fun build(): FileEditor {
-                if (NonProjectFileWritingAccessProvider.isWriteAccessAllowed(file, project)) {
-                    NonProjectFileWritingAccessProvider.allowWriting(listOf(file))
-                }
+    override fun createEditorAsync(project: Project, file: VirtualFile): AsyncFileEditorProvider.Builder {
+        // isWriteAccessAllowed should not be called from the EDT
+        if (NonProjectFileWritingAccessProvider.isWriteAccessAllowed(file, project)) {
+            NonProjectFileWritingAccessProvider.allowWriting(listOf(file))
+        }
 
-                return ExcalidrawEditor(project, file)
-            }
+        return object : AsyncFileEditorProvider.Builder() {
+            override fun build() = ExcalidrawEditor(project, file)
         }
+    }
 }