fix: detect loongarch cpu in header #2128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on [GCC Loongarch Config](https://github.com/gcc-mirror/gcc/blob/master/gcc/config/loongarch/loongarch-c.cc)
pigzhou
approved these changes
Aug 1, 2024
|
@briansmith can I ping you to review this pr? |
briansmith
requested changes
Oct 4, 2024
| @@ -42,9 +42,9 @@ | |||
| #elif !(defined(__ORDER_LITTLE_ENDIAN__) && (__BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__)) && \ | |||
| !(defined(__ORDER_BIG_ENDIAN__) && (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__)) | |||
| #error "Unsupported endianness" | |||
| #elif defined(__LP64__) | |||
| #elif defined(__LP64__) || defined(__loongarch64) || defined(__loongarch_lp64) | |||
There was a problem hiding this comment.
Why is this needed? Does GCC for the 64-bit target not define __LP64__? https://loongson.github.io/LoongArch-Documentation/LoongArch-toolchain-conventions-EN.html says it is defined so this shouldn't be needed.
| #define OPENSSL_64_BIT | ||
| #elif defined(__ILP32__) | ||
| #elif defined(__ILP32__) || defined(__loongarch__) |
There was a problem hiding this comment.
Wouldn't this addition be better placed ...
| #define OPENSSL_64_BIT | ||
| #elif defined(__ILP32__) | ||
| #elif defined(__ILP32__) || defined(__loongarch__) | ||
| #define OPENSSL_32_BIT | ||
| // Versions of GCC before 10.0 didn't define `__ILP32__` for all 32-bit targets. | ||
| #elif defined(__MIPSEL__) || defined(__MIPSEB__) || defined(__PPC__) || defined(__powerpc__) || defined(__csky__) || defined(__XTENSA__) |
There was a problem hiding this comment.
...here, with all the other similar ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on GCC Loongarch Config