Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding history #150

Closed
wants to merge 14 commits into from
Closed

Forwarding history #150

wants to merge 14 commits into from

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Nov 23, 2023

In this PR apis are added to fetch the forwarding revenue made per token.
The forwarding revenue comes for forwarding payments, not opening channels. So the fees that were charged for channel opens (which is in fact a routing fee) are excluded.
Forwards are associated to a token if the channel was opened with that token.
Forwarding revenue for a specific token can also be made if it's not us who has a channel to the user, but another LSP, and that LSP routed a payment through us. The external lsp can export its forwards associated with tokens, using the minimal necessary information. These forwards can then be imported to make them part of the revenue report. The external forwards are associated to local forwards to associate these local forwards to a token.

TODO:

  • Give each forward a unique identifier to dedup.
  • Make sure the channelpoint for cln is correct. Update if necessary.
  • Create a server method to fetch revenue per api key.
  • Figure out what to do with the channel backup and forwarding history backup
    • manually insert old/closed channels?
    • discuss whether it's ok to resync all this data
  • test whether this setup gives the correct revenue per api key
  • disallow creating a revenue report if the data hasn't been synced recently
  • update glightning dependency
  • indices in the database

@JssDWt JssDWt force-pushed the forwarding-history branch 14 times, most recently from 638da72 to 4ec5274 Compare November 30, 2023 13:21
@JssDWt JssDWt force-pushed the forwarding-history branch 14 times, most recently from 4319130 to 2698fca Compare December 7, 2023 08:09
@JssDWt JssDWt force-pushed the forwarding-history branch 2 times, most recently from 3a475f7 to d079eb7 Compare December 8, 2023 12:03
@JssDWt JssDWt force-pushed the forwarding-history branch 6 times, most recently from ecf4a28 to 06f8394 Compare December 14, 2023 08:49
@JssDWt JssDWt force-pushed the forwarding-history branch from 44381a8 to 57ecbaa Compare December 22, 2023 10:03
@JssDWt JssDWt force-pushed the forwarding-history branch from 059f673 to 6e641c7 Compare December 29, 2023 12:04
@JssDWt JssDWt force-pushed the forwarding-history branch from 6e641c7 to 39ab369 Compare December 29, 2023 12:10
@JssDWt JssDWt requested review from roeierez and yaslama December 29, 2023 12:20
@JssDWt JssDWt marked this pull request as ready for review December 29, 2023 12:20
@JssDWt JssDWt closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant