Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckeditor version 4 -> 5 #25

Closed
wants to merge 2 commits into from
Closed

Conversation

TatevikGr
Copy link

No description provided.

@bramley
Copy link
Owner

bramley commented Feb 10, 2025

@michield Please can you explain the background to this? Is the requester part of the phplist.com setup?

@bramley
Copy link
Owner

bramley commented Feb 13, 2025

@TatevikGr @michield Please can you explain the background to this change? It appears to discard some of the existing functionality of the plugin and isn't a "drop-in" replacement which behaves in exactly the same way.

@michield I think that using CKEditor 5 should be in a new plugin, as you suggested earlier phpList/phplist3#1062 (comment)

@TatevikGr
Copy link
Author

@TatevikGr @michield Please can you explain the background to this change? It appears to discard some of the existing functionality of the plugin and isn't a "drop-in" replacement which behaves in exactly the same way.

If CKEditor 5 does not meet your needs as a direct replacement for the existing functionality, I will create a separate plugin instead. The idea was to integrate CKEditor 5 as a modern alternative.

@michield
Copy link
Contributor

Yes, I agree that a CKeditor5 plugin is better made in a new plugin. @bramley yes, @TatevikGr is commissioned by phplist.com to do this work

@bramley bramley closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants