Skip to content

Conversation

@ShubhamGupta05
Copy link
Contributor

@ShubhamGupta05 ShubhamGupta05 commented Jul 8, 2025

Description

Main Purpose: This pull request updates the NPS Survey library by enhancing the code structure, improving versioning, and changing the API endpoint to utilize a new domain.

Key Changes:

  • The main file nps-survey-script.php now prevents multiple inclusions by checking if the script has already been loaded. It also updates the API domain and endpoint to point to https://metrics.brainstormforce.com/ and modifies the endpoint path accordingly.
  • The composer.json file has been added, specifying the development dependencies and scripts for code formatting, linting, testing, and generating stubs.
  • The version number for the plugin has been updated from 1.0.7 to 1.0.11 in multiple locations to reflect the new release.

Additional Notes:

  • Reviewers should check the changes to the NPS Survey API endpoint to ensure functionality remains intact with the new domain.
  • It's also important to run tests against the added Composer script commands to verify that they work as expected in the local development environment.
  • The shift in versioning highlights the need for thorough testing prior to deploying this updated library to ensure compatibility with existing setups.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@sushmak02 sushmak02 merged commit 52e99d4 into next-release Jul 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants