-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and standardise tooling #46
Conversation
Tests seem to be failing because neuromorpho.org is down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait for neuromorpho.org to come back up?
REMOTE_URL = "https://fishatlas.neuro.mpg.de/neurons/download/download_all_neurons_aligned" | ||
REMOTE_URL = ( | ||
"https://fishatlas.neuro.mpg.de/neurons/download/" | ||
"download_all_neurons_aligned" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this link dead?
@@ -162,9 +166,11 @@ def download_dataset(self): | |||
|
|||
shutil.rmtree(extracted_data_path.parent) | |||
|
|||
# # 2/1900 neurons still have a little bug, hopefully fixed in the future | |||
# # 2/1900 neurons still have a little bug, hopefully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed, or is it still needed as pseudo documentation?
neuromorpho is down until at least january. @IgorTatarnikov haven't made any functional changes in this PR, so I suggest we raise issues and merge as is? |
Sounds good 👍, thanks! |
No description provided.