Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional atlas validation functions. #453

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jan 28, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?
Improves our validation functions based on experiences with

so the above issues will be flagged automatically during packaging in the future, when we merge #445

Also, refactors our validation tests for simplicity, and makes sure we are actually testing validation functions on a valid atlas (for the tests we expect them to pass).

@alessandrofelder alessandrofelder marked this pull request as ready for review January 28, 2025 17:33
@alessandrofelder
Copy link
Member Author

Note that one of the new validation functions catches asymmetry in labels on #451, a real-life example.

Failed validations:
('validate_mesh_matches_image_extents', "('Mesh coordinate 20156.5 and annotation coordinate 22932.0', 'differ by more than 10 times pixel size 91.0')")
('validate_annotation_symmetry', 'Annotation labels are asymmetric.')

Mesh extent validation is also expected for that atlas (there are some spurious pixels in the original data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant