Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct wrong linking order to fix static build #1101

Closed
wants to merge 1 commit into from

Conversation

Syping
Copy link
Contributor

@Syping Syping commented Mar 2, 2024

Build DPP statically causing linker errors with OpenSSL with undefined references

/usr/bin/ld: s3_lib.c:(.text+0x348): undefined reference to `OPENSSL_sk_pop_free'
/usr/bin/ld: s3_lib.c:(.text+0x35c): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x377): undefined reference to `CRYPTO_clear_free'
/usr/bin/ld: s3_lib.c:(.text+0x38b): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x39f): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x3ab): undefined reference to `EVP_PKEY_free'
/usr/bin/ld: s3_lib.c:(.text+0x3b7): undefined reference to `EVP_PKEY_free'
/usr/bin/ld: s3_lib.c:(.text+0x3d3): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x3e7): undefined reference to `CRYPTO_free'
/usr/bin/ld: s3_lib.c:(.text+0x440): undefined reference to `CRYPTO_free'

So i corrected the linking order to fix that problem.

Code change checklist

  • [ N/A ] I have ensured that all methods and functions are fully documented using doxygen style comments.
  • [ N/A ] My code follows the coding style guide.
  • [ Yes ] I tested that my change works before raising the PR.
  • [ Yes ] I have ensured that I did not break any existing API calls.
  • [ Yes ] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Mar 2, 2024
@github-actions github-actions bot closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants