Dynamic page margins v2 #2458
Open
Dynamic page margins v2 #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure if I had to add |
This function will receive the pageNumber as argument. This commit is a port of original work of @seahorsepip in pull request bpampuch#1746 This rework is rebuild on 0.3 version, it adds some unit tests for new helpers and it has integration tests following comments in original pull request bpampuch#1746.
Trim
force-pushed
the
page-margin-function
branch
from
e41c761
to
c9deb65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a port of original work of @seahorsepip in pull request #1746
This rework is rebuild on 0.3 version, it adds some unit tests for new helpers and it has integration tests following comments in original pull request #1746.
For the request of having access to
pageCountfrom the function, I think it's not possible, becausepageMargins()is called on each page initialization and so the pageCount is still changing.