Feature/table cell vertical alignment #2436

Kran67 · 2022-05-17T08:22:08Z

Table cell vertical alignment - for stack, column, list, text, image, qr, svg

… image, canvas, qr, svg

This reverts commit a0781c5.

Kran67 · 2022-05-17T08:27:26Z

Hi,
You can use table cell vertical alignment with one new property 'verticalAlign' (values: 'middle', 'bottom', see example)

…b.com/SirFull/pdfmake into feature/table_cell_vertical_alignment

jbenjoy2 · 2022-06-01T18:56:07Z

@Gheeks @bpampuch if we could get this feature merged and released asap that would be lovely! Thank you

jbenjoy2 · 2022-06-06T17:30:03Z

@Gheeks @bpampuch if we could get this feature merged and released asap that would be lovely! Thank you

@bpampuch definitely need to get this feature released asap so if we could please get this merged and released, we'd all really appreciate it.

Sliffcak · 2022-06-07T14:11:13Z

Agreed. Eager for this feature. Thanks for your work!

maxpropp · 2022-06-10T07:15:29Z

Can't wait for this to be merged

dumbasPL

why do we need all the begin/end - Vertical alignment comments everywhere? Git already shows a nice diff.
Alos why do we need the __ prefix everywhere? Rest of this project seems to use "normal" names.

dumbasPL · 2022-06-09T14:02:34Z

src/LayoutBuilder.js

+ // begin - Vertical alignment
+ const lastNode = this.__nodesHierarchy.pop();
+ lastNode.__contentHeight = Math.max(...columns.map(c => c.__contentHeight));
+ this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


there is a missing check for this.__nodesHierarchy.length > 0

dumbasPL · 2022-06-09T14:04:45Z

src/LayoutBuilder.js

@@ -613,6 +648,10 @@ class LayoutBuilder {
 this.writer.removeListener('lineAdded', addMarkerToFirstLeaf);

 this.writer.context().addMargin(-gapSize.width);
+ // begin - Vertical alignment
+ const lastNode = this.__nodesHierarchy.pop();
+ this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


another missing check for this.__nodesHierarchy.length > 0

dumbasPL · 2022-06-10T07:17:01Z

src/TableProcessor.js

+ cellHeight = table.__rowsHeight[rowIndex].height;
+ }
+ if (cellHeight) {
+ const pageItems = writer._context.pages.flatMap(x => x.items);


Note for people porting this to the 0.2 branch: This line needs to be

const pageItems = writer.writer.context.pages.flatMap(x => x.items);

taken from bpampuch/pdfmake#2436

Kran67 · 2022-06-10T07:52:08Z

why do we need all the begin/end - Vertical alignment comments everywhere? Git already shows a nice diff. Alos why do we need the __ prefix everywhere? Rest of this project seems to use "normal" names.

begin/end - Vertical alignment> only for information
Prefix __ is only to avoid future naming conflicts

maxpropp · 2022-06-22T08:19:22Z

are there news regarding this?

Sliffcak · 2022-07-26T15:18:00Z

Any estimate on when this can be merged? I think this feature will greatly improve pdfmake tables!

fe-art · 2022-08-31T09:37:04Z

Guys please, we've been asking for this feature since 2014 ❤️

DanielOfCourse · 2022-09-26T15:50:05Z

It would be so awesome to have this merged in, plsplspls

use paddingTop in processTableVerticalAlignment

maxpropp · 2022-10-26T11:28:24Z

Is there a problem with this PR? So we can update it and finally merge it?

ChrisSimoniMBT · 2022-11-17T15:23:32Z

@Kran67 have you addressed the changes so this can get merged?

ChrisSimoniMBT

Added what I believe are the suggested changes so we can rebase inside github if desired.

ChrisSimoniMBT · 2022-11-17T15:24:45Z

src/LayoutBuilder.js

+ // begin - Vertical alignment
+ const lastNode = this.__nodesHierarchy.pop();
+ lastNode.__contentHeight = Math.max(...columns.map(c => c.__contentHeight));
+ this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


Suggested change

this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;

this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Suggested check

ChrisSimoniMBT · 2022-11-17T15:25:23Z

src/LayoutBuilder.js

@@ -613,6 +648,10 @@ class LayoutBuilder {
 this.writer.removeListener('lineAdded', addMarkerToFirstLeaf);

 this.writer.context().addMargin(-gapSize.width);
+ // begin - Vertical alignment
+ const lastNode = this.__nodesHierarchy.pop();
+ this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;


Suggested change

this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;

this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Suggested check

ChrisSimoniMBT · 2022-11-17T15:29:44Z

@bpampuch @liborm85 Any input on this PR?

nw-onediscovery · 2022-11-29T18:37:20Z

Would love to see this feature merged soon.

MarcBollmann · 2022-12-14T07:40:41Z

Still waiting for this to be merged 👍🏼

…tical_alignment

giangnghiemdinh · 2023-08-08T04:50:06Z

@bpampuch @liborm85 Please release this feature. Many thanks.

merabtenei · 2023-09-07T08:34:15Z

Is there any logical reason why this branch is still not merged ? This is a really important feature.

t0m-4 · 2023-09-14T09:28:34Z

Wel I am in the team that created this PR. Is there any point in me taking the comments into account? will the PR eventually be integrated?

anthonygacis · 2023-10-01T03:38:00Z

update pls.

manuelncfa · 2023-11-06T14:57:30Z

I'm in need of this feature, could this be merged and released?

jdwit · 2024-02-09T14:27:28Z

Would be great if this is merged 👍

KostyanWest · 2024-04-01T11:43:49Z

I prefer to install this library from the SirFull's fork rather than wait for this PR to be merged. Fortunately, package managers such as npm can do it directly from github from the specific branch:
npm install SirFull/pdfmake#table_cell_vertical_alignment
or from the specific commit:
npm install SirFull/pdfmake#aec02a68af06c44991ae3dc45bdf443dde570ba4
I'm not sure any update will be as important as this one.

Miguel LOPES added 3 commits May 17, 2022 10:08

Feat(Table cell vertical alignment) - for text, stack, columns, list,…

0aef943

… image, canvas, qr, svg

Fix: CRLF

a0781c5

Revert "Fix: CRLF"

640a9d1

This reverts commit a0781c5.

sirfullTom and others added 5 commits May 17, 2022 15:44

fix indentation

f528db6

init sfs repo

acdfca7

updated the build

7df5ef2

Fix : function name & lineHeight

5787e4a

Merge branch 'feature/table_cell_vertical_alignment' of https://githu…

ad3e102

…b.com/SirFull/pdfmake into feature/table_cell_vertical_alignment

Sliffcak mentioned this pull request May 18, 2022

Align text in a table column vertically #74

Open

Gheeks approved these changes May 23, 2022

View reviewed changes

dumbasPL suggested changes Jun 10, 2022

View reviewed changes

dumbasPL added a commit to Createch-Corp/pdfmake that referenced this pull request Jun 10, 2022

add Table cell vertical alignment

3dbdf2b

taken from bpampuch/pdfmake#2436

sirfullTom and others added 3 commits October 25, 2022 18:03

use paddingTop in processTableVerticalAlignment

ecba23b

Merge pull request #1 from SirFull/fix/padding-vertical-alignment

0795850

use paddingTop in processTableVerticalAlignment

updated version

a46dee1

ChrisSimoniMBT suggested changes Nov 17, 2022

View reviewed changes

sirfullTom added 5 commits March 23, 2023 10:56

Merge branch 'master' into release/vertical_alignment

22607e0

build 0.3.0-beta.5

e86a99e

Merge branch 'release/vertical_alignment' into feature/table_cell_ver…

aec02a6

…tical_alignment

update package name to remove @SirFull

20092c6

update oiriginal repo url

8549dba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/table cell vertical alignment #2436

Feature/table cell vertical alignment #2436

Kran67 commented May 17, 2022

Kran67 commented May 17, 2022

jbenjoy2 commented Jun 1, 2022 •

edited

jbenjoy2 commented Jun 6, 2022

Sliffcak commented Jun 7, 2022

maxpropp commented Jun 10, 2022

dumbasPL left a comment

dumbasPL Jun 9, 2022

dumbasPL Jun 9, 2022

dumbasPL Jun 10, 2022

Kran67 commented Jun 10, 2022

maxpropp commented Jun 22, 2022

Sliffcak commented Jul 26, 2022

fe-art commented Aug 31, 2022

DanielOfCourse commented Sep 26, 2022

maxpropp commented Oct 26, 2022

ChrisSimoniMBT commented Nov 17, 2022

ChrisSimoniMBT left a comment

ChrisSimoniMBT Nov 17, 2022

ChrisSimoniMBT Nov 17, 2022

ChrisSimoniMBT commented Nov 17, 2022

nw-onediscovery commented Nov 29, 2022

MarcBollmann commented Dec 14, 2022

giangnghiemdinh commented Aug 8, 2023

merabtenei commented Sep 7, 2023

t0m-4 commented Sep 14, 2023 •

edited

anthonygacis commented Oct 1, 2023

manuelncfa commented Nov 6, 2023

jdwit commented Feb 9, 2024

KostyanWest commented Apr 1, 2024

	this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight;
	this.__nodesHierarchy.length > 0 && (this.__nodesHierarchy[this.__nodesHierarchy.length - 1].__contentHeight += lastNode.__contentHeight);

Feature/table cell vertical alignment #2436

Are you sure you want to change the base?

Feature/table cell vertical alignment #2436

Conversation

Kran67 commented May 17, 2022

Kran67 commented May 17, 2022

jbenjoy2 commented Jun 1, 2022 • edited

jbenjoy2 commented Jun 6, 2022

Sliffcak commented Jun 7, 2022

maxpropp commented Jun 10, 2022

dumbasPL left a comment

Choose a reason for hiding this comment

dumbasPL Jun 9, 2022

Choose a reason for hiding this comment

dumbasPL Jun 9, 2022

Choose a reason for hiding this comment

dumbasPL Jun 10, 2022

Choose a reason for hiding this comment

Kran67 commented Jun 10, 2022

maxpropp commented Jun 22, 2022

Sliffcak commented Jul 26, 2022

fe-art commented Aug 31, 2022

DanielOfCourse commented Sep 26, 2022

maxpropp commented Oct 26, 2022

ChrisSimoniMBT commented Nov 17, 2022

ChrisSimoniMBT left a comment

Choose a reason for hiding this comment

ChrisSimoniMBT Nov 17, 2022

Choose a reason for hiding this comment

ChrisSimoniMBT Nov 17, 2022

Choose a reason for hiding this comment

ChrisSimoniMBT commented Nov 17, 2022

nw-onediscovery commented Nov 29, 2022

MarcBollmann commented Dec 14, 2022

giangnghiemdinh commented Aug 8, 2023

merabtenei commented Sep 7, 2023

t0m-4 commented Sep 14, 2023 • edited

anthonygacis commented Oct 1, 2023

manuelncfa commented Nov 6, 2023

jdwit commented Feb 9, 2024

KostyanWest commented Apr 1, 2024

jbenjoy2 commented Jun 1, 2022 •

edited

t0m-4 commented Sep 14, 2023 •

edited