-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show the asset path in the workbench #998
Conversation
@mensinda I like the concept in fact I always wanted to have the asset somehow directly shown. One problem though is that it is pretty common for it to be somewhat long which
for the overflow maybe we can restrict it to max size, truncating the start and just show the end of the path. Then when hovering on the text, we'd see the whole path. for the cluttered part, I've been thinking to have a selector to choose different "view mode" next to the pagination. It would show more or less information based on the mode. One other info pretty useful to have is the "repository name" when doing cross repository searches. So we could have a condensed view, which the current display and and expanded view which would show the repository name and repository path. To avoid having to deal with length of the path, I think it would make sense to just have the path on its own line. Any thoughts on that? Wondering if you have other information besides the path that you feel should be directly accessible. |
726b36b
to
74bb02f
Compare
Implemented by setting the max width to
Implemented.
I have also added this.
Not that I can currently think of. |
74bb02f
to
b55ce64
Compare
Thanks @mensinda ! edit:
Potentially, on its own line before the locale/string id, Have 2 labels prefixed with "repo" eg. "repo: demo" and other "asset: demo.properties". I think "grey" would be fine for those |
webapp/src/main/resources/public/js/components/workbench/ViewModeDropdown.js
Outdated
Show resolved
Hide resolved
webapp/src/main/resources/public/js/components/workbench/TextUnit.js
Outdated
Show resolved
Hide resolved
|
||
return ( | ||
<OverlayTrigger placement="top" overlay={assetPathTooltip}> | ||
<Label style={{maxWidth: "256px", overflow: "hidden"}} bsStyle='info' bsSize='large' className="clickable" onClick={this.onAssetPathClick}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment on the style/color and the prefix/be on its own line.
webapp/src/main/resources/public/js/stores/workbench/ViewModeStore.js
Outdated
Show resolved
Hide resolved
b55ce64
to
fd75e6f
Compare
fd75e6f
to
46ae8ab
Compare
This moves the resource button next to the locale. Additionally, the resource path of a text is now always shown and not hidden behind a tooltip: