Skip to content

Add delay on error #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Add delay on error #3068

wants to merge 2 commits into from

Conversation

dschwoerer
Copy link
Contributor

Sometimes the backtrace is not printed. I think it might be a race between flushing stdout and mpi_abort.

As this is racy, I am not sure how to test this, but think a delay of 0.1 seconds should not matter, and might help (at least sometimes).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -47,6 +47,8 @@ class PhysicsModel;
#include "bout/unused.hxx"
#include "bout/utils.hxx"

#include <chrono>
#include <thread>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: included header chrono is not used directly [misc-include-cleaner]

Suggested change
#include <thread>
#include <thread>

@@ -47,6 +47,8 @@
#include "bout/unused.hxx"
#include "bout/utils.hxx"

#include <chrono>
#include <thread>
#include <type_traits>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: included header thread is not used directly [misc-include-cleaner]

Suggested change
#include <type_traits>
#include <type_traits>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant