Skip to content

Add Installer: Eve Online Settings Manager #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lostcoastwizard
Copy link
Contributor

  • update index.yml
  • add eveonlinesettingsmanager.yml
  • add eveonlinesettingsmanager.md
  • add github-mark-white.png

Type of change

  • New installer
  • Manifest fix
  • Other

Was This Tested Using a Local Repository?

  • Yes
  • No

lostcoastwizard and others added 3 commits October 20, 2024 02:42
- add eveonline.png
- add game eveonline.yml
- add review eveonline.md
- update index.yml
- update index.yml
- add eveonlinesettingsmanager.yml
- add eveonlinesettingsmanager.md
- add github-mark-white.png
@mirkobrombin
Copy link
Member

Hi, thanks for your contribution.

Why is this using a white (bad contrast in Bottles) github icon for the program?

@lostcoastwizard
Copy link
Contributor Author

I just grabbed the first one from the official icon pack without checking. I will update it.

- remove github-mark-white.png
- add github-mark.png
@jntesteves
Copy link
Contributor

I think we have never had an installer like this before. There are no dependencies, there is no install step, and in current state there isn't even checksum verification. The program is just an exe you can download and run directly and is rarely updated. In my opinion an installer isn't needed for this. People should be able to download an exe and add a shortcut in Bottles on their own since that's what Bottles is meant for.

If we were to merge this installer I'd at least want checksum verification, but I'm skeptical of the value here and I wouldn't merge.

What do you think @mirkobrombin ?

@lostcoastwizard
Copy link
Contributor Author

lostcoastwizard commented Jun 10, 2025

There are no dependencies because it runs without needing any installed. I can add a checksum. I use this program and so do other people. This saves the process of manual installation.

@jntesteves
Copy link
Contributor

There are no dependencies because it runs without needing any installed. I can add a checksum. I use this program and so do other people. This saves the process of manual installation.

The thing is, there is no process of manual installation. People can run this program in Bottles the same way they'd run it on Windows.

@lostcoastwizard
Copy link
Contributor Author

lostcoastwizard commented Jun 10, 2025

I missed the fact that you can just path the exe from outside the bottle. Would be nice for players but either way. Feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants