Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added poll to the Message object [Suggestion #2201] #1850

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Borbot33
Copy link
Contributor

Suggestion #2201

Screenshots:
image

@ashishjh-bst
Copy link
Contributor

This will also need to be added in MessageState.

@adilla16
Copy link

adilla16 commented Mar 7, 2025

$ git switch -c my-branch master

@botlabs-gg botlabs-gg deleted a comment from adilla16 Mar 18, 2025
@@ -415,6 +415,7 @@ type MessageState struct {
MentionRoles []int64
Attachments []discordgo.MessageAttachment
Stickers []discordgo.Sticker
Poll *discordgo.Poll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, take reference of messageForwards support, you'll also have to add helpers to convert poll to value from pointer when saving to state.

Reference PR

https://github.com/botlabs-gg/yagpdb/pull/1744/files#diff-07490940a040da9cec20ec7da7c3a8a1b62c3b90dae49a44aef9f40fa1c506a6

Copy link
Contributor

@ashishjh-bst ashishjh-bst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still missing critical code for being functional,
Reference PR for adding new items to message struct

https://github.com/botlabs-gg/yagpdb/pull/1744/files#diff-07490940a040da9cec20ec7da7c3a8a1b62c3b90dae49a44aef9f40fa1c506a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants