-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/lambda functions #230
Open
ybastide
wants to merge
15
commits into
main
Choose a base branch
from
task/lambda-functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02d5394
to
e10ebf4
Compare
43ca4a0
to
6351703
Compare
6351703
to
a4c6164
Compare
Signed-off-by: Yves Bastide <[email protected]>
Unfortunately, boto2 doesn't support passing lambdaRole; we must override two of its methods (register type and start workflow). Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Currently SWF only; needs to be moved upward. And with some rough edges... Signed-off-by: Yves Bastide <[email protected]>
"name" is really set to "id" (more useful). Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
* use workflow_config.`get('defaultLambdaRole')` instead of [] (not already present, at least in tests) * rename my_* to custom_* Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
This at least document its format :-) Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
Currently SWF only; needs to be moved upward. And with some rough edges... Signed-off-by: Yves Bastide <[email protected]>
"name" is really set to "id" (more useful). Signed-off-by: Yves Bastide <[email protected]>
Signed-off-by: Yves Bastide <[email protected]>
aa25d37
to
e8912ae
Compare
jbbarth
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey dear @ybastide I hope everything's OK on your side :) Adding a "review ok" here to reduce noise in my Github "Pulls" dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing:
simpleflow.LambdaFunctionTask
?