Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish_release: git tagging procedure #82

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sdarwin
Copy link
Contributor

@sdarwin sdarwin commented Oct 22, 2024

Includes the 'git tag' commands in publish_release.py.

This is a step closer to having publish_release.py take care of everything in the release.

It's opt-in with the --git-tag flag. Otherwise nothing changes, and tagging can be done manually as before.

@sdarwin sdarwin requested a review from mclow October 23, 2024 17:46
@sdarwin
Copy link
Contributor Author

sdarwin commented Oct 23, 2024

@mclow what steps do you follow with rc release candidate git tags? Do you skip that completely? Or tag and then delete later?

@sdarwin
Copy link
Contributor Author

sdarwin commented Nov 5, 2024

@mclow please review when you have a chance. I tested these changes and it seems fine. Before the "git push" step, the script pauses and allows you to check git tags locally and decide if they should be pushed to github.

@sdarwin sdarwin force-pushed the git_checkout_3 branch 2 times, most recently from 3516e8c to 27fadab Compare November 22, 2024 17:05
@sdarwin sdarwin merged commit 27a1d55 into boostorg:develop Jan 8, 2025
1 check passed
@mclow
Copy link
Contributor

mclow commented Jan 8, 2025

A quick question here - are you tagging the HEAD of each of the modules, or the commit that is referenced in the super-project?

They ought to be the same - but sometimes someone commits something to 'master' even though we tell them not to - and turn off automatic merging to the super project?

@sdarwin
Copy link
Contributor Author

sdarwin commented Jan 8, 2025

are you tagging

Consider the steps on https://github.com/boostorg/wiki/wiki/Releases%3A-Preparing

git submodule update --init --recursive --checkout
git tag boost-1.78.0
git submodule foreach 'git tag boost-1.78.0'
git push origin boost-1.78.0
git submodule foreach 'git push origin boost-1.78.0'

Is the wiki correct?
Those are the steps the script is following, so it should be the same.

Since "git submodule update" will retrieve the commit referenced by the superproject, that will be the tagged commit.

Also, immediately before "git push", the script pauses, and you can check the state of the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants