Make static_vector<T,N> trivially relocatable when T is trivially relocatable #263
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR definitely isn't ready for prime time, but I figured I might as well exploit Cunningham's Law here.
The idea is that when the compiler supports
__cpp_impl_trivially_relocatable(P1144's proposed feature-test macro), then we should define-DBOOST_CONTAINER_ATTRIBUTE_TRIVIALLY_RELOCATABLE_IF(x)=[[trivially_relocatable(x)]]. (And/or set it to a vendor-specific attribute if-and-when anyone supports a vendor-specific attribute; no mainstream compiler does, yet.)The big problem with this patch as it stands right now is that I have no idea where these macros are configured. We want to do the same thing that
BOOST_CONTAINER_ATTRIBUTE_NODISCARDdoes; but that's not configured anywhere in this repo, either.I see that Boost.Container is just inheriting all its type-traits from Boost.Move, so probably
dtl::is_trivially_relocatablebelongs in Boost.Move, not here?Fixes #258.