Allow kernel argument to take custom struct by value #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosenrodt
force-pushed
the
pr-kernel-pass-struct-by-value
branch
from
11401ed
to
b040362
Compare
rosenrodt
force-pushed
the
pr-kernel-pass-struct-by-value
branch
from
b040362
to
e1b96b3
Compare
|
It looks like Apple platform regards custom struct as invalid kernel argument. That's weird because my 2016 Macbook works just fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specializing
template<T> struct set_kernel_argwhen expanding BOOST_COMPUTE_ADAPT_STRUCT, kernel input argument can now take custom struct by value. This potentially utilizes constant memory of the compute device