Develop #142
Develop #142
Conversation
boostcamp3-iOS#12 스크롤뷰(90%) , 섹션
move to feature/MainView branch
| @@ -703,6 +605,30 @@ extension ItemViewController: UICollectionViewDelegate, UICollectionViewDataSour | |||
| navigationController?.pushViewController(SeeMoreRestVC, animated: true) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| func sendDataToStoreVC(tableViewSection: TableViewSection, indexPath: IndexPath) { | ||
|
|
||
| guard let storeViewController = UIStoryboard.main.instantiateViewController(withIdentifier: "CollectionViewController") |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
| return .init() | ||
| } | ||
|
|
||
| private func setTableViewSectionCell(_ tableviewSection: TableViewSection, indexPath: IndexPath) -> UITableViewCell { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 14 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 55 lines (function_body_length)
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
| return UIEdgeInsets(top: 30, left: 30, bottom: 30, right: 30) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
File Line Length Violation: File should contain 400 lines or less: currently contains 412 (file_length)
| } | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 162 characters (line_length)
| tablecell.collectionView.reloadData() | ||
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { |
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 47 lines (function_body_length)
| @IBOutlet var scrollView: UIScrollView! | ||
| private var images: [String] = ["1_1", "2_1", "3_1", "4_1", "5_1", "6_1"] | ||
| private var frame = CGRect(x: 0, y: 0, width: 0, height: 0) | ||
| private var labelString: [String] = ["추천요리", "가까운 인기 레스토랑", "예상 시간 30분 이하", "Uber Eats 신규 레스토랑", "주문시 5천원 할인 받기", "가나다라", "마바사", "아자차카", "타파하", "아아아앙아", "집에", "가고", "싶다"] |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 174 characters (line_length)
No description provided.