Add missing appProtocol

[cmk-jarek]

Hey, ive encountered strange behavior inside and ipv6 eks cluster and traced it to set the right protocol when using (mandatory) (m)tls.
if you do not do this, the ingress will wait for your first input and the welcome header wont get transmitted to the sender. didnt open an issue as this fix was pretty obvious

[bokysan]

Hi,

thanks so much for catching this. What would be the default in this case -- "smtp", I assume? As this is a feature of k8s>1.20, I'd probably guard it behind a version flag (like this).

What do you think?

[cmk-jarek]

Hey, definitely a good idea to add the version requirements. as on the protocols, k8s unfortunately is pretty flat, it basically treats any higher level proto wrt to thair layer 4 protocol(osi), it only supports http/s, proxy and tls protocols natively, anything else it passes through as tcp/udp. so TL/DR <https://kubernetes.io/docs/reference/networking/service-protocols/> the default would be tcp

…

On Fri, Apr 26, 2024 at 4:09 PM Boky ***@***.***> wrote: Hi, thanks so much for catching this. What would be the default in this case -- "smtp", I assume? As this is a feature of k8s>1.20, I'd probably guard it behind a version flag (like this <https://github.com/bokysan/docker-postfix/blob/master/helm/mail/templates/hpa.yaml#L6> ). What do you think? — Reply to this email directly, view it on GitHub <#197 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BB24TA376Y23MEOCCQGKZ2TY7JNZHAVCNFSM6AAAAABG2ZULNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGQ3TCNZVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Checkmk - The IT monitoring platform | checkmk.com <https://www.checkmk.com/> Subscribe to our newsletter <https://checkmk.com/community/newsletter>! | Melden Sie sich bei unserem  Newsletter <https://checkmk.com/de/community/newsletter> an! Checkmk GmbH Kellerstrasse 27, 81667 Munich, Germany Commercial Register: Local Court Munich, HRB 165902 Managing Director: Jan Justus

[cmk-jarek]

added the version requirements, not sure about the formatting as im not use to go that much yet, and my linter was already complaining before i touched the code, so feel free to correct me ;)
i dont see the necessity to explicitly set the default, as it would probably work just fine if you run a common setup.
can add that tmrw if you like ,tho. :)