Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector for the ServiceMonitor currently will not match the underlying service:
app.kubernetes.io/instance: {{ $chart }}
will only work if the release is namedmail
, because$chart
is hard-coded to that value here. But that's not always the case.prometheus: unknown
will cause this to never match because this label isn't applied to the underlying service (unless it is explicitly set in the values provided the helm chart).Fixes #162