Use Debian Slim as base image #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Could I kindly ask you to rebase and squash? |
|
I rebased it now, but I am making these commits through the Github Web UI so I dont think I can squash them |
bokysan
reviewed
Oct 27, 2023
Dockerfile
Outdated
| @@ -1,6 +1,6 @@ | |||
| # syntax=docker/dockerfile:1.2 | |||
|
|
|||
| ARG BASE_IMAGE=debian:latest | |||
| ARG BASE_IMAGE=debian-slim:latest | |||
There was a problem hiding this comment.
This is wrong. That's why the integration test is failing.
|
Pull request seems to work, but we really need to rebase and squash it. There are literary 5 changes but 10 commits and I cannot merge it because it says "This branch cannot be rebased due to conflicts". |
|
Replaced by #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make the docker image a lot smaller