Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dockerize #7

wants to merge 2 commits into from

Conversation

json2d
Copy link

@json2d json2d commented Oct 13, 2018

Added support for deploying with Docker, including usage notes.

Make sure to change the repo namespace from json2d to bobbens when merging, in Dockerfile and README.md

make sure to change the repo namespace from `bitstrider` to `bobbens` when merging
@bobbens
Copy link
Owner

bobbens commented Mar 20, 2019

I can't comment on the docker pull request much as I don't use docker, but it is likely that you will have to make the docker image use pytorch 0.4.1 and not latest (see issue #8 )

@json2d
Copy link
Author

json2d commented Mar 22, 2019

you're right thanks for the tip

@json2d
Copy link
Author

json2d commented Mar 22, 2019

unfortunately there's no 0.4.1 image available

https://hub.docker.com/r/pytorch/pytorch/tags

do you know if 0.4.0 works?

@bobbens
Copy link
Owner

bobbens commented Mar 22, 2019

I assume it would, but someone would have to test it to make sure.

./figs.sh
python simplify.py --img test_line.png --out out_rough.png --model model_pencil2.t7
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After building this image and running it interactively, inside the shell, running figs.sh gives:

root@da71b5a52837:/workspace/sketch_simplification# ./figs.sh
Processing fig01_eisaku.png...Traceback (most recent call last):
File "simplify.py", line 4, in
from torch.utils.serialization import load_lua
ModuleNotFoundError: No module named 'torch.utils.serialization'
root@da71b5a52837:/workspace/sketch_simplification#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants